tkrajina / srtm.py

Geo elevation data parser for "The Shuttle Radar Topography Mission" data
Apache License 2.0
240 stars 57 forks source link

fix(list.json): fix the incorrect URLs in list having several // instead of / #54

Open pierresouchay opened 2 years ago

pierresouchay commented 2 years ago

Because those URLs do not work:

curl https://srtm.kurviger.de/SRTM3//Eurasia//N35E139.hgt.zip

does not work anymore (changes on Cloudfront side recently?)

While

curl https://srtm.kurviger.de/SRTM3/Eurasia/N35E139.hgt.zip

works as expected

pierresouchay commented 2 years ago

Really weird, works for some URLs, but not others... wondering if it is not an CloudFlare issue:

$ [22/06 2:43:59] $ curl  https://srtm.kurviger.de/SRTM3//Eurasia//N35E139.hgt.zip
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /SRTM3//Eurasia//N35E139.hgt.zip was not found on this server.</p>
<hr>
<address>Apache Server at srtm.kurviger.de Port 80</address>
<script defer src="https://static.cloudflareinsights.com/beacon.min.js/v652eace1692a40cfa3763df669d7439c1639079717194" integrity="sha512-Gi7xpJR8tSkrpF7aordPZQlW2DLtzUlZcumS8dMQjwDHEnw9I7ZLyiOj/6tZStRBGtGgN6ceN6cMH8z7etPGlw==" data-cf-beacon='{"rayId":"71f512b5bac50877","token":"ba837d8dfae748f7bc3691ea638fa5a7","version":"2022.6.0","si":100}' crossorigin="anonymous"></script>
</body></html>

[22/06 2:44:02] $ curl  https://srtm.kurviger.de/SRTM3/Eurasia/N35E139.hgt.zip
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

=> Double // breaks download

But:

[22/06 2:51:29] $ curl https://srtm.kurviger.de/SRTM1//Region_07//N00W177.hgt.zip
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

=> works...

Still, to me, the patch makes sense