tkrajina / typescriptify-golang-structs

A Golang struct to TypeScript class/interface converter
Apache License 2.0
506 stars 87 forks source link

Migrate fork from xinhuang327 #4

Closed Fank closed 5 years ago

Fank commented 6 years ago

New stuff:

I think thats all

Fank commented 6 years ago

@tkrajina if you could merge this one, i could continue open a PR with my changes

tkrajina commented 6 years ago

OK, finally I found a couple of hours to do a review of this PR. This is now much better, but:

There are other commits which aren't immediately obvious what they do. For example 4dcb518545777c4662cb3641a736efea99aea3c8. It would be a huge help if there was a test for it. Keep in mind -- if there is a feature I don't use from this project, it's still me who will fix bugs in this code later.

Ideally, I'd like the following features:

Fank commented 6 years ago

I also don't know most of it, this is just a migrate PR. Which i can't maintain, because its just the base for the next PR ill open if this is merged, which will contain my changes, where i can do all the stuff you commented above.