search

tkrajina / typescriptify-golang-structs

A Golang struct to TypeScript class/interface converter
Apache License 2.0
505 stars 87 forks source link

Minus to underscore in package names #49

Closed aubelsb2 closed 2 years ago

aubelsb2 commented 3 years ago

This works for me.. I often use - to separate my github repos, which I suspect my IDE (golang) converts to _ when creating the package name.

Eitherway - isn't a valid character so this isn't creating any new failures.

tkrajina commented 2 years ago

Hm, OK, I can see that there might me things to fix here, but this explanation is too vague for me: merging something that shouldn't cause problems because we suspect an IDE is doing something.

I need a clearer problem explanation (if possible with a test to easily reproduce the bug).

tkrajina commented 2 years ago

BTW, https://github.com/tkrajina/typescriptify-golang-structs/commit/ade46320e2ec51dd24239234ef2955c9190e1759 should fix this problem.