search

tkrebes / nisyscfg-python

NI System Configuration Python API
MIT License
4 stars 0 forks source link

Self-Calibrate #53

Closed ni-jfitzger closed 1 year ago

ni-jfitzger commented 1 year ago

Is your feature request related to a problem? Please describe. This API looks pretty awesome, but the self_calibrate function appears to be missing.

It's available in the LabVIEW API for hardware resources, but I don't see it anywhere in this API.

tkrebes commented 1 year ago

Thanks for the complement. I created PR #54 with a potential implementation. I'm out on vacation and do not have the means to test the change at the moment. But, if the change works for you, I can complete the PR and publish a new package on pypi.org.

Regards, -Tyler

ni-jfitzger commented 1 year ago

It worked for me. Flake8 seems to want a blank line at the end of the file.

Thanks,

[https://www.ni.com/content/dam/web/scene7/email/signature/email-sig-logo.png] Jay Fitzgerald Staff Software Engineer Modular Instruments & Vision Driver Ownership - External ni.comhttps://www.ni.com/ [https://www.ni.com/content/dam/web/scene7/email/signature/email-sig-banner.png]https://www.ni.com/r/zf03uz

INTERNAL - NI CONFIDENTIAL From: Tyler Krehbiel @.> Sent: Thursday, June 8, 2023 10:35 AM To: tkrebes/nisyscfg-python @.> Cc: Jay Fitzgerald @.>; Author @.> Subject: Re: [tkrebes/nisyscfg-python] Self-Calibrate (Issue #53)

Thanks for the complement. I created PR #54https://urldefense.com/v3/__https:/github.com/tkrebes/nisyscfg-python/pull/54__;!!FbZ0ZwI3Qg!vQryEQUH3qvoltm_i3JyGjusTjz8EWvL-rAM1bvahaxboLePqzZZjCp_DkpJLC68VVL0WzI65ZcU6tCwFVRjS6fzLRV_cw$ with a potential implementation. I'm out on vacation and do not have the means to test the change at the moment. But, if the change works for you, I can complete the PR and publish a new package on pypi.org.

Regards, -Tyler

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/tkrebes/nisyscfg-python/issues/53*issuecomment-1582840599__;Iw!!FbZ0ZwI3Qg!vQryEQUH3qvoltm_i3JyGjusTjz8EWvL-rAM1bvahaxboLePqzZZjCp_DkpJLC68VVL0WzI65ZcU6tCwFVRjS6fsPRaz-g$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AIEO7ZMCDOPJKW3EY7A6SXLXKHWL7ANCNFSM6AAAAAAYXGWMGE__;!!FbZ0ZwI3Qg!vQryEQUH3qvoltm_i3JyGjusTjz8EWvL-rAM1bvahaxboLePqzZZjCp_DkpJLC68VVL0WzI65ZcU6tCwFVRjS6fns0D4yA$. You are receiving this because you authored the thread.Message ID: @.***>

tkrebes commented 1 year ago

Closing, #54 has been merged into main.