search

tkrkt / text2png

text-to-png generator for Node.js
MIT License
188 stars 50 forks source link

Stroke #37

Closed philipeachille closed 5 years ago

philipeachille commented 5 years ago

Thanks for the easy to use module.

Would it possible for you to add stroke options to the module (width and color)?

Best PAV

philipeachille commented 5 years ago

Added this myself just now. How can I create a pull request? I cant publish my branch ...

tkrkt commented 5 years ago

If you give me PR, I’d be happy to merge it. Fork this as your repository, create a branch, push code, and create a PR. It's ok to make mistakes!

philipeachille commented 5 years ago

I get an error when trying to push: "remote: Permission to tkrkt/text2png.git denied to philipeachille."

tkrkt commented 5 years ago

First you need to fork this repository.

https://hisham.hm/2016/01/01/how-to-make-a-pull-request-on-github-a-quick-tutorial/

(I should write guidelines for repository contributors. Sorry for the inconvenience.)

philipeachille commented 5 years ago

thanks for the link, I now created the pull request