search

tkrotoff / jquery-simplecolorpicker

Very simple jQuery color picker
http://plnkr.co/edit/VVclW0?p=preview
MIT License
386 stars 87 forks source link

Keyboard Support #19

Closed Deklin closed 11 years ago

Deklin commented 11 years ago

Enables Keyboard support when in picker mode and not in picker mode

  1. When picker launches, auto-selects first button using focus()
  2. Pressing TAB navigates will wrap in the picker
  3. Pressing ESC on a selected node will close the picker and not select anything
  4. Pressing ENTER on a selection option will select that like a mouse click would in PICKER and NON-PICKER mode.

There is one defect I commented with a FIXME that I am working on, it has to do with auto-focusing $icon after performing a hidePicker, ESC is bubbling up to my bootstrap modal and i've not fixed that yet.

tkrotoff commented 11 years ago

Also you can kill off commits with Git using git rebase -i. Rewriting history should be used with caution, but in this case instead of reverting a commit (982f22a) it's worth it.

The init function starts to be big now and needs some refactoring, this will be another step :)

Deklin commented 11 years ago

Added some of the changes you suggested, others i'll get to tomorrow.

Deklin commented 11 years ago

Hello any update on this pull request? What remaining items would you like fixed?

tkrotoff commented 11 years ago

I didn't receive any email notification related to your new commits inside your own repository. Hopefully with your latest comment I was sent an email notification.

A quick check show me that jquery.simplecolorpicker.js is full of tabs and trailing spaces. This is what SublimeText displays:

tabs and spaces

You should configure your text editor/IDE to remove the trailing spaces and switch to 2 spaces for the indentation.

And the Git history starts to be difficult to follow :/

Deklin commented 11 years ago

I'll reissue a new pull request to make it easier On Nov 28, 2013 6:53 AM, "Tanguy Krotoff" notifications@github.com wrote:

I didn't receive any email notification related to your new commits inside your own repository. Hopefully with your latest comment I was sent an email notification.

A quick check show me that jquery.simplecolorpicker.js is full of tabs and trailing spaces. This is what SublimeText displays:

[image: tabs and spaces]https://github-camo.global.ssl.fastly.net/b683e041b2b02ae4fae103eadc0bd70957c9b20d/687474703a2f2f7331372e706f7374696d672e6f72672f766332766665636c722f323031335f31315f32385f31325f32305f31375f435f55736572735f74616e6775795f44726f70626f785f6465762e706e67

You should configure your text editor/IDE to remove the trailing spaces and switch to 2 spaces for the indentation.

And the Git history starts to be difficult to follow :/

— Reply to this email directly or view it on GitHubhttps://github.com/tkrotoff/jquery-simplecolorpicker/pull/19#issuecomment-29458688 .