Theme folder + fontello theme

crlcu commented 11 years ago

Hi,

I have made a folder for theme and added fontello theme support.

tkrotoff commented 11 years ago

Hi,

Thanks for your pull request.

demo.html is broken
About the use of Fontello I don't understand why you want a theme for Fontello since Fontello is not a font but a font generator.
About the minified files I don't think the minified files should be inside the repository (for me it's like having C/C++ binaries - .exe, .dll, .so... inside a repository alongside the source code). I know this is a common practice for JS files but I don't see the benefit: people will anyway minify the code they depend on using Grunt, Rails asset pipeline or whatever framework they use.

crlcu commented 11 years ago

Hi, Sorry, it looks that I forgot to push the latest commit.

I added the minified files just to shorten the time for installing this library.

tkrotoff commented 11 years ago

Sorry but I cannot include a font that you have generated yourself.

The check/ok mark that you are using seems to come from FontAwesome, I suggest you to change the code for this icon inside Fontello and set it to U+F00C so you can re-use jquery.simplecolorpicker-fontawesome.css instead of creating your own .css file.

tkrotoff / jquery-simplecolorpicker

Theme folder + fontello theme #21