tkshill / Quarto

A working example of the Quarto board game using Elm and Netlify. An exploration of game development, OSS, and functional programming.
https://elmquarto.netlify.app/
MIT License
15 stars 16 forks source link

When saving site as PWA with firefox, icon image does not appear #54

Open tkshill opened 3 years ago

tkshill commented 3 years ago

Describe the bug

After trying to install the app as a PWA, the image icon doesn't show up.

20201107_175512

Expected behavior There should be an image from the favicon showing up.

Smartphone (please complete the following information):

- Device: Galaxy A21s
 - OS: Android 10
 - Browser Firefox Beta 
 - Version 83.0.0 

Additional context

{ "name": "Elm Quarto", "short_name": "Elm Quarto", "description": "Functional and accessible web app based on the popular (and highly entertaining) board game Quarto.", "icons": [ { "src": "/android-chrome-192x192.png", "sizes": "192x192", "type": "image/png" }, { "src": "/android-chrome-512x512.png", "sizes": "512x512", "type": "image/png" } ], "theme_color": "#000000", "background_color": "#ffffff", "display": "standalone" }


We only make mention of android-chrome. It may be necessary to add more to the icons list?

Any help would be appreciated on this.

**UPDATE**
[This web.dev article](articlehttps://web.dev/maskable-icon-audit/?utm_source=lighthouse&utm_medium=lr) seems to describe the problem. Apparently, the images in the icons may need a "purpose" field to enable that functionality. 

---

See [here](https://github.com/tkshill/Quarto/blob/main/README.md#run-and-install) in the read me for how to run and install the application.

See [here](https://github.com/tkshill/Quarto/blob/main/CONTRIBUTING.md#the-basics) in contributing for the basics on forking and cloning the repository.
github-actions[bot] commented 3 years ago

Thank you for the issue! We'll take your request into consideration and will follow up soon if we decide to tackle this issue. To all contributors: any issue that is labeled Status: Available is up for grabs. To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please leave a comment letting us know and we can schedule some time to help. For full info on how to contribute, please check out our contributors guide.