search

tksk / jing-trang

Automatically exported from code.google.com/p/jing-trang
0 stars 0 forks source link

missing VoidVisitor.voidVisitZeroOrMore #102

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the expected output? What do you see instead?

In mod/rng-schema/src/main/com/thaiopensource/relaxng/edit/VoidVisitor.java,
there are final methods returning VoidValue, and calling abstract methods
void voidVisitXXXX().

This is not the case of visitZeroOrMore(), which calls voidVisitPattern().
It is particularly disturbing, since visitOneOrMore() does have a
voidVisitOneOrMore() method. 

What version of the product are you using? On what operating system?

jing-trang-20090818, or Jing from trunk.

Please provide any additional information below.

This is what I would like :

public final VoidValue visitZeroOrMore(ZeroOrMorePattern p) {
    voidVisitZeroOrMore(p);
    return VoidValue.VOID;
  }

  public void voidVisitZeroOrMore(ZeroOrMorePattern p) {
    voidVisitPattern(p);
    p.getChild().accept(this);
  }

Original issue reported on code.google.com by neri...@wanadoo.fr on 17 Jan 2010 at 8:33