tktcorporation / vrchat-join-recorder

VRChat の Join 情報を記録し、あとから World 情報を振り返る デスクトップApp
0 stars 0 forks source link

82/fix #100

Closed tktcorporation closed 5 months ago

tktcorporation commented 5 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

変更は、Electronアプリケーション全体のリファクタリングとエラーハンドリングの改善、UIの調整に焦点を当てています。主な変更には、electronUtilRouterの導入、エラークラスの追加、新しいテストケースの追加、コンポーネント構造のリファクタリングが含まれます。

変更

ファイル 変更概要
electron/api.ts getController関数をelectronUtilRouterに置き換え、subscribeToast内のエラーハンドリングを調整
electron/module/service.ts VRChatLogFileErrorVRChatPhotoFileErrorのインポートを追加し、getWorldJoinInfoWithPhotoPathの戻り値を修正
electron/electronUtil.ts, .../electronUtil/controller/electronUtilController.ts getWindow関数を定数としてエクスポートし、openUrlInDefaultBrowserelectronUtilRouterにリファクタリング
.../joinLogInfoFile/service.spec.ts, .../joinLogInfoFile/service.ts エラーハンドリングをパターンマッチングで改善し、新しいテストケースを追加
electron/module/service/utilsService.ts reloadWindow関数を追加し、他の関数と共にエクスポート
electron/module/service/vrchatPhoto/error.ts, .../vrchatPhoto/service.ts エラークラスVRChatPhotoFileErrorを導入し、getVRChatPhotoOnlyItemPathListByYearMonthの戻り値を変更
src/components/JoinInfoPreview.tsx item.tookPhotoListの長さに基づく条件チェックをコメントアウト
src/page/photoList/CreateJoinInfo.tsx, .../PhotoList.tsx, .../WorldInfo.tsx UI構造の調整、エラーハンドリングの改善、コンポーネント構造のリファクタリング

Poem

🐰 うさぎが書いた詩 🐰

月夜にコードを編む、小さなうさぎ 🌙
エラーと戦いながら、新たな道を探す
ブラウザを跳ねて、窓を開ける
変更の風、航海の準備はできて
今宵も、デジタルの森を駆ける 🌲🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
github-actions[bot] commented 5 months ago

Related issue

tktcorporation commented 5 months ago
github-actions[bot] commented 5 months ago

screenshot

github-actions[bot] commented 5 months ago

screenshot

github-actions[bot] commented 5 months ago

screenshot

github-actions[bot] commented 5 months ago

screenshot