search

tkuester / taky

A simple python TAK server
MIT License
184 stars 43 forks source link

Handle absent course and speed attributes #88

Closed robertkleffner closed 9 months ago

robertkleffner commented 12 months ago

Some of our CoT payloads don't have course and speed attributes (actually they don't have a track element) in the detail element. This was causing an exception in taky and it wasn't propagating the packets to ATAK clients.

With this change, the packets propagate as we expect (and are used to from FTS).

However, if this is considered invalid CoT and acceptable to not handle, I am willing to withdraw the PR.

tkuester commented 12 months ago

Thanks for the request! This is something I didn't consider when writing taky, and I'm enthralled someone is submitting pull requests.

I will be on travel this weekend, but I will take my laptop and see if I can get this merged.

On Thu, Jul 20, 2023 at 12:59 PM Robert Kleffner @.***> wrote:

Some of our CoT payloads don't have course and speed attributes (actually they don't have a track element) in the detail element. This was causing an exception in taky and it wasn't propagating the packets to ATAK clients.

With this change, the packets propagate as we expect (and are used to from FTS).

However, if this is considered invalid CoT and acceptable to not handle, I am willing to withdraw the PR.

You can view, comment on, or merge this pull request online at:

https://github.com/tkuester/taky/pull/88 Commit Summary

File Changes

(1 file https://github.com/tkuester/taky/pull/88/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/tkuester/taky/pull/88, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQVTMY3GUS7OM6OTMPOBTLXRFPVRANCNFSM6AAAAAA2RW4TSE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

pusewicz commented 10 months ago

Bump @tkuester

tkuester commented 9 months ago

Merged into 65b627b on the next branch!

I did a rebase and squash of the typo commit to try and keep the history a little tidier. Thanks for your submission!