tkurki / marinepi-provisioning

Ansible provisioning scripts to set up a Raspberry Pi for marine use
Apache License 2.0
45 stars 21 forks source link

Armv6 node upgrade support #54

Closed mairas closed 5 years ago

mairas commented 5 years ago

I'm stuck to armv6 on the Raspberry Pi Zero W. This PR adds support to conditionally upgrading the installed Node.js version (and bumps the Node.js version from 6.x to 10.x...).

chacal commented 5 years ago

Looks good to me. I wonder what happens if the provisioned Pi doesn't have internet connection when the latest available Node .tar.gz is checked? Does the Ansible run terminate or does it just somehow skip updating Node?

mairas commented 5 years ago

And I thought I'd considered all the corner cases... :-p Now, Ansible barfs only if Node is not installed. This does make sense: changes to SK configuration no longer require internet connectivity.

tkurki commented 5 years ago

Last time I looked sqlite@charts plugin had trouble with Node 10, one reason why we are recommending 8.