search

tkurz / skosjs

A javascript-based skos editor. Test the editor on http://tkurz.github.com/skosjs/
Apache License 2.0
39 stars 10 forks source link

Invalid SPARQL query in SKOS client #24

Open jaw111 opened 11 years ago

jaw111 commented 11 years ago

The query to create a new concept is not valid as it contains an empty WHERE {} clause. Previously this was WHERE { ?s ?p ?o }.

Locally I modified the query to INSERT DATA in line the the query to create a top concept.

tkurz commented 11 years ago

Great stuff!

Can you send me a patch for this, would be nice to merge your local fixes back!

Best Regards Thomas

jaw111 commented 11 years ago

Hi Thomas, What is the best method to do this, to be honest I'm still just getting started with Git and Github. John

Date: Thu, 27 Jun 2013 05:33:43 -0700 From: notifications@github.com To: skosjs@noreply.github.com CC: johnawalker@hotmail.com Subject: Re: [skosjs] Invalid SPARQL query in SKOS client (#24)

Great stuff!

Can you send me a patch for this, would be nice to merge your local fixes back!

Best Regards

Thomas

— Reply to this email directly or view it on GitHub.

tkurz commented 11 years ago

Hi John

actually it is quite simple. Create the patch and append it to the issue. The command for it is git-format-patch

Here is a short description. https://openhatch.org/wiki/How_to_generate_patches_with_git_format-patch

That is maybe the easiest way.

Thx in advance! Thomas

Am 29.06.2013 um 11:36 schrieb jaw111 notifications@github.com:

Hi Thomas, What is the best method to do this, to be honest I'm still just getting started with Git and Github. John

Date: Thu, 27 Jun 2013 05:33:43 -0700 From: notifications@github.com To: skosjs@noreply.github.com CC: johnawalker@hotmail.com Subject: Re: [skosjs] Invalid SPARQL query in SKOS client (#24)

Great stuff!

Can you send me a patch for this, would be nice to merge your local fixes back!

Best Regards

Thomas

— Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.

Thomas Kurz Knowledge and Media Technologies Salzburg Research Tel: +43/622/2288-253

tkurz commented 10 years ago

Hi John,

can you send me a pull request to your fork. This would be the easiest way to integrate your patch into the current master. It is described here: https://help.github.com/articles/using-pull-requests

Regards Thomas