search

tkyaji / cordova-plugin-crypt-file

This plugin to encrypt the source files.
Apache License 2.0
179 stars 116 forks source link

Fix hook platforms restriction #36

Closed duddu closed 7 years ago

duddu commented 7 years ago

Moved the platforms restriction (ios/android) inside the after_prepare hook

duddu commented 7 years ago

Hi, first of all thanks a lot for this plugin, it does its job very well. I have a little issue with the execution of the after_prepare hook: a simple cordova prepare (without any platform specified) won't trigger the hook, leaving the platforms assets not encrypted. It could be a problem for some people who need to run a single prepare for all the platform - like me :) - and can generate confusion.

The issue comes from this commit: Hook applies only to iOS and Android platforms

This commit simply filters the platforms from the cli with the ones declared by the plugin. May be fine? There are consequences that I have not thought of?