FIxes #96 Second Try, Rich Text Editor using tinymce

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.

Apache License 2.0

4 stars 6 forks source link

FIxes #96 Second Try, Rich Text Editor using tinymce #103

Closed danie1zhang closed 2 years ago

jonespm commented 2 years ago

This looks good!

I did a minor change to the settings to add a comma in the list and also provide a slightly different default config that adds the menu bar in which I think is useful. I also added a migration which I don't believe does anything to the data field. Will double check this but looks okay.

I filed an issue for dark mode detection in the repository, but everything else looked better than the other plugin to me.

jonespm commented 2 years ago

@danie1zhang Is this ready to move out of draft? I think we're good to merge this and close the other one.