Add keydown action along with onclick on Learn More and Exit Buttons

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.

Apache License 2.0

4 stars 6 forks source link

Add keydown action along with onclick on Learn More and Exit Buttons #116

Closed jonespm closed 2 years ago

jonespm commented 2 years ago

When using tab and enter to navigate learn more doesn't do anything. We need to be keyboard accessible on these buttons

https://github.com/tl-its-umich-edu/canvas-app-explorer/blob/5fc86c13a0c289ebbf5b96e58213db2e2fdd4255/frontend/components/Home.jsx#L239

ssciolla commented 2 years ago

This was partially resolved by #152, but there are a couple more things that need fixing.

ssciolla commented 2 years ago

This should be fully resolved after merging #158. We'll need to make sure any future changes to buttons also use proper instrumentation, but Material UI should handle much of this out of the box.