search

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.
Apache License 2.0
4 stars 6 forks source link

Fixes #164 - Simplify local development to only need one forward #165

Closed jonespm closed 2 years ago

jonespm commented 2 years ago

After this and #159 are committed this seems to work fine under Loophole.

Need to update: https://github.com/tl-its-umich-edu/canvas-app-explorer/wiki/Configuring-LTI-1.3

jonespm commented 2 years ago

Lots of fixes/updates from code review on https://github.com/tl-its-umich-edu/canvas-app-explorer/pull/165/commits/b1851dac8ec618e9f98627be045d747f103e816f.

These seem to be working for me now. I think my problem earlier today was a combination of nvm and bind mount permissions with the suggested change to npm run. But this is all working.

It might work with the old bind mounts but those weren't actually working like they were supposed to based on the reading here. It looks like we should only bind the directories we need locally.

I thought about putting node_modulesup at a higher level but there were some modules that still seemed to be writing to thenode_modules/.cache in frontend directory.