search

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.
Apache License 2.0
4 stars 6 forks source link

Add a dialog for viewing larger versions of screenshots (#185) #199

Closed ssciolla closed 2 years ago

ssciolla commented 2 years ago

This PR aims to resolve #185.

ssciolla commented 2 years ago

@zqian and @jonespm, there should be no conflicts here now, it's ready for review.

jonespm commented 2 years ago

It looks like Zhen had good feedback and this looks good to me. Do you know how this looks if the image is too big, like if someone uploads a 4000px image? I think we'll have to implement the fix for resizing to get both images and thumbnails sooner. https://picsum.photos/4000

ssciolla commented 2 years ago

Do you know how this looks if the image is too big, like if someone uploads a 4000px image? I think we'll have to implement the fix for resizing to get both images and thumbnails sooner.

@jonespm, do we have an issue open for this? I did test this just now, it loads pretty slow, with some amount of the image loading in strips. Re-sizing would make sense, or some other image handling mechanisms the whole image appears at once, even if delayed. This could be postponed if we just advise our users on size limitations, or enforce it programmatically?