search

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.
Apache License 2.0
4 stars 6 forks source link

Fixes #212 Switch database for localhost from mysql-server back to original mysql #213

Closed jonespm closed 2 years ago

jonespm commented 2 years ago

Thanks! I've noticed this does works better on M1 and also on Windows. I know we don't have a lot of Windows users but @chrisrrowland and some students have worked on our projects in the past so we probably should have something consistent that works best for everyone.

jonespm commented 2 years ago

I didn't try the test, thanks for the catch. Yeah, I'll add that change back into this PR. We have had to use it in Student Explorer, I think using this image would make it easier to migrate over other projects.

zqian commented 2 years ago

This change works for my M1 too. I noticed the DBeaver connection broke recently for canvas_app_explorer_mysql, but that may be a different problem.

I can still do docker exec -it canvas_app_explorer_mysql mysql -u cae_user --password=cae_p to get to mysql interface.

jonespm commented 2 years ago

I got DBeaver to connect as root after this but I had to re-add it as MySQL again so it used the MySQL 8 driver. For the mysql-server it mentions it generates a random root password that you have to pull from the logs which seems more cumbersome since we're just using it for local development. mysql-server seems more likely to be an image that you'd use on an actual Linux server and mysql seems more optimized for local use.

jonespm commented 2 years ago

I pushed the previous fix to run the init script. It can connect now but I don't have it configured.

Do we have the way to run this script and the environment variables documented anywhere?

ssciolla commented 2 years ago

I pushed the previous fix to run the init script. It can connect now but I don't have it configured. Do we have the way to run this script and the environment variables documented anywhere?

I think just in .env.sample. We can add paragraph in the README about testing. All you do is mint yourself a personal access token and set the url and course ID.