IDs of 'add-tool-button' and 'remove-tool-button' were flagged by a11y check for not being unique.

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.

Apache License 2.0

4 stars 6 forks source link

IDs of 'add-tool-button' and 'remove-tool-button' were flagged by a11y check for not being unique. #226

Closed jonespm closed 2 years ago

jonespm commented 2 years ago

The issue that the aXe checker flagged was` ‘Ensures every id attribute value of active elements is unique’ because these buttons have a hardcoded id. Perhaps we could just pass in and append the id of the tool cards. Unless there's some better recommendation for unique ids in React.

https://github.com/tl-its-umich-edu/canvas-app-explorer/blob/de65c5c7eb76903fe535ea9befd54229c96af060/frontend/app/components/toolButtons.tsx#L9

ssciolla commented 2 years ago

Yeah, I was too cavalier with the IDs. I will make them unique.

zqian commented 2 years ago

verified this issue is no longer flagged by Axe DevTools.