search

tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.
Apache License 2.0
4 stars 6 forks source link

Add tool name to card under the logo image (#229) #234

Closed ssciolla closed 2 years ago

ssciolla commented 2 years ago

This PR aims to resolve #229.

jonespm commented 2 years ago

I wonder if we could just reduce the height of the logo a little rather than increasing the card height? Maybe Janel has some feedback on that?

Our logos images do seem a little larger (296x150) than ones on comparable sites like Wolverine Access (48x48) and EduAppCenter (200x104) and Google Play (56x56)

Going from 150 to 115 doesn't seem like that big of a loss but it does leave more whitespace on the sides of the images.

ssciolla commented 2 years ago

I wonder if we could just reduce the height of the logo a little rather than increasing the card height?

Do you want me to change that here? Somewhat out of scope. I agree with what you said, they are rather large, but there's the potential for whitespace on the sides if the images aren't sized or cropped just right.

jonespm commented 2 years ago

We probably don't need to change it here, just noticed it and saw the cards getting bigger. Can create a new issue and ask about it at the next meeting. Can just reduce the image and card height in that fix if we feel they're too big.