tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.
Apache License 2.0
4 stars 6 forks source link

Database images aren't cached, add cache control #241

Closed jonespm closed 2 years ago

jonespm commented 2 years ago

I noticed that images that are loaded from the database aren't cached. This is going to put unnecessary load and extra traffic on us with every request

image

I found this thread here about how we can pass headers along to this url.

TEST PLAN:

image

If a new image is uploaded the name is changed, so I think this caching for this default recommended year is fine.

ssciolla commented 2 years ago

I can QA this.

zqian commented 2 years ago

verified the LTI logo images are cached.