tl-its-umich-edu / canvas-app-explorer

A Web application that presents a list of Canvas external (LTI) tools with details. When integrated within Canvas, the user can search for specific LTI tool(s), and add or remove those tools from Canvas courses.
Apache License 2.0
4 stars 6 forks source link

Validate the launch closer to the actual launch #262

Open jonespm opened 2 years ago

jonespm commented 2 years ago

I believe some issues with launch validation might be because we are waiting a bit to do any launch validation.

If we explicitly validate the launch immediately after the launch we shouldn't encounter issues with the validation not matching, and if so be able to handle it better in our code.

https://github.com/dmitry-viskov/pylti1.3#lti-message-launches

I'm not sure if we'd need to implement any locking around this. We're doing more testing. I believe that if the testing is successful just having a validate closer to the launch should be sufficient.

https://github.com/tl-its-umich-edu/canvas-app-explorer/blob/a7a8f86bbb651b61e47c49716988db430c0dbca0/backend/canvas_app_explorer/lti1p3.py#L182