tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

Footer n-nn of n will not be announced when it changes. #258

Closed pushyamig closed 2 years ago

pushyamig commented 2 years ago

Location: confirmation screen of Gradebook formatter, Add UM users, Create sections. Impact: Critical. Type: Semantics and Structure Issue Footer n-nn of n will not be announced when it changes.

Impact Screen reader users will be unaware anything has happened after a paging action.

Solution Add aria-live="polite" to the container so that changes are announced.

ssciolla commented 2 years ago

It looks like we can fix this easily as suggested by adding aria-live="polite" somewhere. However, I'd like to consult with the accessibility team on how high to place this property. Putting it on each feature container may make sense, but I don't know all the implications.

pushyamig commented 2 years ago

@ssciolla check with @gsliver on this.

ssciolla commented 2 years ago

@gsilver, can you provide your perspective on this please? We could certainly add polite to the table container, but with an SPA, I start to wonder if really polite should just be at each page container, or at the root container even.

gsilver commented 2 years ago

@ssciolla @pushyamig - updates need to be as succinct as possible. This is what aria-atomic and aria-relevant were supposed to address, but there is some variability on how screen reader/ua combinations reinterpret and report changes to the accessibility tree, hence our recommendation that aria-live be restricted to smaller elements that report on the changes, not the element containing the changes themselves. We loose a bit of control when we add aria-live to large containers wrapping complex hierarchies that may change. Rather prefer to report "x has changed in this way" and then allow the user to navigate to x and note the changes. Hope this makes sense. BTW - the aria-live value should be "polite"

gsilver commented 2 years ago

aria-live="polite" for the win