search

tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

Add `aria-live` to `TablePagination`, remove it from `AddNonUMUsers` container (#258) #317

Closed ssciolla closed 2 years ago

ssciolla commented 2 years ago

Per feedback received on #258 to use aria-live more granularly, this PR proposes two changes to aria-live usage in the application:

1) add aria-live='polite' as instructed to the container for the table pagination footer where the displayed rows are reported 2) remove aria-live='polite' that was added provisionally to the AddNonUMUsers container, as high-level usages like this are probably noisy and discouraged.

The PR seeks to resolve #258.

pushyamig commented 2 years ago

@ssciolla I can see if you are paginating table, voice over is saying "your are on next page of the table or something similar". But it is still not reading the content of the table. should it?

ssciolla commented 2 years ago

@ssciolla I can see if you are paginating table, voice over is saying "your are on next page of the table or something similar". But it is still not reading the content of the table. should it?

That's probably a question for @gsilver. I would think that would have been asked for in the issue if it was a problem. We could put aria-live='polite' on the table container, but I think the recommendation was to keep it granular. Maybe the thought is that if the page range is updated, the user will know to have table re-read using a command. I'm not sure.