Closed ssciolla closed 5 months ago
Should this be in icebox?
Should this be in icebox?
Yes, I don't think we should tackle this immediately, too many things still in motion it seems.
Quickly tested all features Tested the bulk upload of Add U-M user and Bulk create sections Deleted the token from Canvas Profiles - > setting Let the token Refresh Used the 'act as' feature to test a teacher accessing CCM
I can't test the database migration
Dev test plan was provided is for when reviewing PR and checking that. I think it is already taken care so I will move the issue to Done column
There is a more recent version of
p-limit
, version4
, but it uses ESM, which would require some tinkering withpackage.json
andtsconfig
s, and maybe more dramatic import changes across the project. This should probably be handled separately, and it may not be urgent. I need to do more reading about it. See https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c and https://www.typescriptlang.org/docs/handbook/esm-node.html_Originally posted by @ssciolla in https://github.com/tl-its-umich-edu/canvas-course-manager-next/pull/327#discussion_r798894673_
I've done some more research on this. I will add more links below as I find them:
Resource(s):
Library standpoints:
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
Test Plan Functional testing: This is full feature/regression testing
.mysql_data
so DB could be created. So migrations could be applied.docker-compose-prod.yml