search

tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

Add table captions (#257) #337

Closed ssciolla closed 2 years ago

ssciolla commented 2 years ago

The PR aims to resolve #257.

(I only did minimal testing, but I will do some more. This should do the trick.)

pushyamig commented 2 years ago

A generic question, again not asking for a change.

I read the problem statement, solution discussion with accessibility team. This fix is right one. When I turn on Voice over I don't see the table caption is being read. Is that expected?

ssciolla commented 2 years ago

A generic question, again not asking for a change.

I read the problem statement, solution discussion with accessibility team. This fix is right one. When I turn on Voice over I don't see the table caption is being read. Is that expected?

Are you using Control + Option + A to read all the content on the page? I did test that it worked, but I could have missed something. My current understanding is that screenreader-only text doesn't need to be read automatically (unless it's part of a page change like the footer was), just be present when the screenreader is told to read all the content.

pushyamig commented 2 years ago

just be present when the screenreader is told to read all the content.

Probably I don't know how to trigger the Screen reader to read. I tried the Control + Option + A after your suggestion. But no luck. I am sure I don't now how to use it that's all.

But on other note, I see captions are added as expected. I tested a few, but based on the file changes I can say it will work.

ssciolla commented 2 years ago

just be present when the screenreader is told to read all the content.

Probably I don't know how to trigger the Screen reader to read. I tried the Control + Option + A after your suggestion. But no luck. I am sure I don't now how to use it that's all.

Hm, now I'm having trouble with it. I will see if did something wrong.

ssciolla commented 2 years ago

Hi @pushyamig, I am able to get the table captions to be read by VoiceOver if I use the Control + Option + Command + T combination to locate the table. Please let me know if this works for you. I am following the recommendations of Material UI and W3C in terms of placement, and the hiding CSS should not affect whether it is available to screenreaders.

pushyamig commented 2 years ago

I am able to get the table captions to be read by VoiceOver if I use the Control + Option + Command + T combination to locate the table.

Now I can, thx for the tip on the key options to press. Working as expected.