search

tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

#359 Dependency update #362

Closed pushyamig closed 2 years ago

pushyamig commented 2 years ago

Fixes #359

  1. Created the test plan for all the things I tested with this issue
  2. npm audit show 0 vulnerabilities
  3. tested in both prod and non-prod mode, locally
  4. Created the package-lock.json with new dependencies and once I generated then only I did a docker build/up. Always cleared docker imaged locally before doing a build
  5. Below are things I opted not to do upgrade after discussion with @ssciolla 
 got                                 ^11.8.2  →   ^12.0.2
 notistack                           ^1.0.10  →    ^2.0.3
 p-limit                              ^3.1.0  →    ^4.0.0
 react-router-dom                     ^5.3.0  →    ^6.2.2
 @types/node                       ^16.11.26  →  ^17.0.22
 @typescript-eslint/eslint-plugin    ^4.33.0  →   ^5.16.0
 @typescript-eslint/parser           ^4.33.0  →   ^5.16.0
 eslint                              ^7.32.0  →   ^8.11.0

Note about @kth library. They are going to make the error response object smaller as default in upcoming releases. So that will be a breaking change.

pushyamig commented 2 years ago

Most of these were probably up to date when you released, but they have since been updated. I'd probably try installing the latest versions of all these.

@ssciolla I was able to update to the latest version and ran the test cases and things are ok. Currently these are the libraries I did not update

got                                 ^11.8.2  →   ^12.0.2
 notistack                           ^1.0.10  →    ^2.0.3
 p-limit                              ^3.1.0  →    ^4.0.0
 react-router-dom                     ^5.3.0  →    ^6.2.2
 @types/node                       ^16.11.26  →  ^17.0.22
 @typescript-eslint/eslint-plugin    ^4.33.0  →   ^5.16.0
 @typescript-eslint/parser           ^4.33.0  →   ^5.16.0
 eslint                              ^7.32.0  →   ^8.11.0
zqian commented 2 years ago

Test successful with localhost on latest code (76c2bb4), integrated with Canvas test server.