search

tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

I79 help documentation #386

Closed pushyamig closed 2 years ago

pushyamig commented 2 years ago

Fixes #79 and #110

Preview of the documentation https://pushyamig.github.io/canvas-course-manager-next/

ssciolla commented 2 years ago

Lot of comments out there already. @pushyamig, I will let you work through them first. Happy to review again for grammar, clarity, HTML structure after we've resolved some.

pushyamig commented 2 years ago

Lot of comments out there already. @pushyamig, I will let you work through them first. Happy to review again for grammar, clarity, HTML structure after we've resolved some.

I will work on it in an hour or so.

pushyamig commented 2 years ago

I resolved all the suggestion If I missing some of them sorry since lot of comments. Please look for latest and suggest as needed.

pushyamig commented 2 years ago

@ssciolla I have accepted suggestion with punctuation in the sentence, But other suggestions with improved languages I will stick with what @melindakraft have. I appreciate your feedback!

pushyamig commented 2 years ago

@pushyamig, I think the structure and formatting looks fine. I suggested a couple places where you could up longer lines more.

I took them all, I was just breaking then when ended with a period. But I see you added a break between sentences good for clarity.

@melindakraft I kept the sentence structure as the way you edited this morning. The only thing I changed today is HTML line spacing for code readability, I just changed minor punctuation suggestion which shouldn't be a big deal. so no need for you to review from that. Normally if reviewers are happy with the code they show their consent by clicking the approve button that under Files changed tab -> Review Changes -> Approve (you may also leave some final comments)