tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

`.dockerignore` has incorrect pattern #392

Closed ssciolla closed 2 years ago

ssciolla commented 2 years ago

Current, .dockerignore uses **/env.* for its pattern, which doesn't match the pattern we use in this project for local development, .env. This isn't a big issue because a) the project doesn't expect the .env to be in ccm_web at all (where .dockerignore is), and b) we don't use .env files for deployment builds.

However, as a precaution, it seems right to fix this, as it's possible a file could be moved into ccm_web inadvertently, and locally built images could be pushed to a remote image stream.

pushyamig commented 2 years ago

Test passes. Tested locally.