402: properly cast string course_id to number for global variable

tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.

8 stars 9 forks source link

402: properly cast string course_id to number for global variable #409

Closed jaydonkrooss closed 4 months ago

jaydonkrooss commented 5 months ago

Consume course_id from canvas Id token as a string, then cast as a number for the globals API endpoint response

pushyamig commented 5 months ago

@jaydonkrooss I will review this today or tomorrow.

pushyamig commented 4 months ago

I don't see a need to add additional check if checking courseID has any letter since Number('AS122) could return NaN. So this change looks good.

couple of linting errors, if they are fixed this PR is good to go

pushyamig commented 4 months ago

Looks Good