tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

418 FE deps update fix UI bugs and unmerging issue #422

Closed jaydonkrooss closed 3 months ago

jaydonkrooss commented 3 months ago

FE Dependency Updates: Minor package updates and addresses UI bugs found in https://github.com/tl-its-umich-edu/canvas-course-manager-next/issues/418 Fixes #408 Bugs addressed:

Also uses material UI upgrade ListItem props to fix the https://github.com/tl-its-umich-edu/canvas-course-manager-next/issues/408

Bugs not identified:

pushyamig commented 3 months ago

Alignment issue b/w small and big window inside features workflow Unmerging text/spinner is missing when unmerging feature Create single Section textbox has alignment issue

I mostly see the issues might have solved

pushyamig commented 3 months ago

What exact styling fixed the pagination mis-alignment?

pushyamig commented 3 months ago

Overall I see all the styling issues seems to be solved including the unmerging bug. I have one issue with linting and some questions on PR about the approach, if those are resolved this PR is ready to be merged. Nice work @jaydonkrooss !

pushyamig commented 3 months ago

@jaydonkrooss Let's have this merged today or Tomorrow. Then I can take this change to my PR with CSRF library move.

jaydonkrooss commented 3 months ago

What exact styling fixed the pagination mis-alignment?

Screenshot 2024-03-26 at 4 07 29 PM

When you said that pagination was broken, I thought that might have referred to the pagination buttons not being in the correct flex configuration. maybe misalignment is the wrong word, but it required a small styling change to make sure they were all listed in one row as seen in the picture (it used to be split into two rows)