tl-its-umich-edu / canvas-course-manager-next

Canvas Course Manager Next: A redesign of the existing CCM application. It extends Canvas features, makes cumbersome features easier to use, and adds new features.
8 stars 9 forks source link

434: put loading spinner backdrop inside enrollment section accordion #436

Closed jaydonkrooss closed 2 months ago

jaydonkrooss commented 2 months ago

Fixes #434

I made this change thinking that cleaning up this loading screen was a requirement for another task. Seeing that it introduces a new design decision, I split it out into this PR.

Old loading backdrop

Screenshot 2024-04-18 at 4 58 43 PM

Proposed new loading backdrop

Screenshot 2024-04-18 at 4 58 17 PM
pushyamig commented 2 months ago

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Linking a PR with issues using fixes will close the issue when the PR is closed. Look for more info in the provided link

pushyamig commented 2 months ago

Linking a commit with the issue using #: https://gitdailies.com/articles/link-github-commit-to-issue/#:~:text=How%20to%20Link%20Commits%20to,link%20in%20the%20commit%20message.