tl-its-umich-edu / canvas

Integration scripts between ITS TL and Instructure Canvas
Other
3 stars 8 forks source link

remove unnecessary log error message from the sis_set_url script #122

Closed zqian closed 2 years ago

zqian commented 2 years ago

There are some patterns of API error we can safely log as WARN log messages, instead of ERROR log messages. That will help trigger less Jenkins alert emails.

  1. "set url result for section id=
    with Canvas courseId=: result status=Failure and result message=Unable to find Class/Term Combination"
  2. "There is no sectionString value with result value {"ClassNumberData":null}"
  3. "Null response JSON value for Canvas API call"

The mail command at the end of the sis_set_url.rb script can also be removed, since we now use the email feature supported by Jenkins service