tl-its-umich-edu / canvas

Integration scripts between ITS TL and Instructure Canvas
Other
3 stars 8 forks source link

Monitor enrollment update problem for BluePrint course #148

Open zqian opened 6 months ago

zqian commented 6 months ago

We found a bug where Canvas will let a crosslist with enrollments through to a blueprints course. The fallout is that the sections will stop getting SIS updates when they are in a BP course.

The SIS error is [2023-12-21T02:07:11.466694 #29] INFO -- : upload process warning: [["enrollments.csv", "Student enrollment for \"12345678\" not allowed in blueprint course \"1234567890\""]]

This bug has reported to Canvas. Meanwhile, we need to monitor for this error so we have some notification if it happens?

An example can be found in a recent Jenkins log: https://jenkins.tl.it.umich.edu/job/canvas-sis-prod-sis-upload/1219/consoleFull

jonespm commented 6 months ago

This shouldn't fail the job. We have a way now in Jenkins to mark the job as unstable.

So I believe either this needs to return some status that thejenkins-run script need to return that error code and pass it up to Jenkins. It's possible both things may need adjustment.

I can work with @jaydonkrooss on this. Another error we want to flag for unstable is

["users.csv", "An existing Canvas user with the SIS ID 12345678 has already claimed 87654321's user_id requested login information, skipping"], ["enrollments.csv", "User not found for enrollment (User ID: 87654321, Course ID: , Section ID: 1234567890)"]]

jonespm commented 6 months ago

I'd also look for the message "not allowed in blueprint course" since it could be an error about observers or students (currently).

We might want to make the messages we want to flag configurable.

It might be the best/easiest idea for jenkins-run.sh to also just check for all of the messages rather than modify each job. We'd have to talk about this. If we made the list of messages configurable it would be easier to make changes I think if/when Canvas or other vendors changed their messages.

So this might need to be moved over to https://github.com/tl-its-umich-edu/openshift-jenkins-configs