search

tl-its-umich-edu / canvas

Integration scripts between ITS TL and Instructure Canvas
Other
3 stars 8 forks source link

reorg of properties file setup for sis_upload.rb #24

Closed zqian closed 9 years ago

zqian commented 9 years ago

Currently, we invoke sis_upload.rb via the following format:

ruby sis_upload.rb PATH_TO_TOKEN_FILE SERVER_URL WORKING_DIRECTORY_PATH

In the future, we want to put token, and service url settings into securities.properties, create another properties.txt file for other properties settings (working directory path and the sleep intervals between Canvas API calls), so the command line format will be:

ruby sis_upload.rb PATH_TO_SECURITY_FILE PATH_TO_PROPERTIES_FILE

dlhaines commented 9 years ago

Why would the working directory need to be in security.properties?

On Fri, Mar 13, 2015 at 1:53 PM, Zhen Qian notifications@github.com wrote:

Currently, we invoke sis_upload.rb via the following format:

ruby sis_upload.rb PATH_TO_TOKEN_FILE SERVER_URL WORKING_DIRECTORY_PATH

In the future, we want to put token, service url, and working directory settings into securities.properties, create another properties.txt file for other properties settings (e.g. the sleep intervals between Canvas API calls), so the command line format will be:

ruby sis_upload.rb PATH_TO_SECURITY_FILE PATH_TO_PROPERTIES_FILE

— Reply to this email directly or view it on GitHub https://github.com/tl-its-umich-edu/canvas/issues/24.

zqian commented 9 years ago

updated based on Dave's feedback.

Security file now have two params: token and server url; and properties file have two params: working directory path and sleep seconds.

zqian commented 9 years ago

code updated based on feedbacks. Close the issue now.