search

tl-its-umich-edu / canvas

Integration scripts between ITS TL and Instructure Canvas
Other
3 stars 8 forks source link

Tlunizin-631 SIS Upload fails silently while creating practice sites #67

Closed zqian closed 9 years ago

zqian commented 9 years ago

added the Canvas API throttling mechanism to SIS upload process

lsloan commented 9 years ago

Other than either a mistake in time calculation or just a bad comment, and the question of whether it's better to just print the information rather than using a logging facility, it seems to be OK.

:shipit:

dlhaines commented 9 years ago

One argument for always using logging is that other developers won't have to figure out where information is or what format it has. It's in the logs. It's not in some non-standard text file. It's not split between the log and some other file.

On Mon, Aug 10, 2015 at 11:23 AM, Lance E Sloan notifications@github.com wrote:

Other than either a mistake in time calculation or just a bad comment, and the question of whether it's better to just print the information rather than using a logging facility, it seems to be OK.

[image: :shipit:]

— Reply to this email directly or view it on GitHub https://github.com/tl-its-umich-edu/canvas/pull/67#issuecomment-129493604 .

lsloan commented 9 years ago

Nice to see the use of a typical logger.

:shipit: