TLPSO-432 This is code for switching to ESB new IBM API Manager

tl-its-umich-edu / canvas

Integration scripts between ITS TL and Instructure Canvas

Other

3 stars 8 forks source link

TLPSO-432 This is code for switching to ESB new IBM API Manager #89

Closed pushyamig closed 6 years ago

pushyamig commented 6 years ago

sis_set_url script update to new esb bus

lsloan commented 6 years ago

Although you didn't ask me to review this PR, I saw the email notification from GH about it, and the "pseudocode" comment got my attention. Why would untested pseudocode be included in a PR? It should be complete and working (tested as much as can be done in a development environment) before it gets pulled into the master branch of the upstream repo.

pushyamig commented 6 years ago

@lsloan, you are correct "pseudocode' would grab anybody's attention. I Opened this earlier because I wanted a way to share the code with Zhen as I got stuck on a problem and I wanted a review so I opened a PR. I fixed the problem now and did not pay attention to the commit comment, I will update the comment

pushyamig commented 6 years ago

I have updated the commit comment now