tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
35 stars 39 forks source link

Fix, replace, or remove Cypress tests #1418

Closed ssciolla closed 1 year ago

ssciolla commented 2 years ago

Currently, the Cypress tests don't run as is following the provided instructions. It seems like there is a dependency issue with cypress-plugin-snapshots (which is unmaintained and not compatible with the latest cypress major version). See https://github.com/meinaart/cypress-plugin-snapshots/issues/215 about possible updates. But even if you pin it to the compatible version, many tests don't pass. This is likely either because the dump data changed or snapshots haven't been updated.

I'll add a note about the issues in the relevant docs, but at some point, it would be nice to get this working, replace it with something like Playwright, or just remove it if we don't plan to keep it up to date.

jonespm commented 1 year ago

Additional cleanup:

jennlove-um commented 1 year ago

Remove the Cypress tests.

pushyamig commented 1 year ago

@jonespm can you QA this?

jonespm commented 1 year ago

I see that they're removed, I don't see any references to cypress.