search

tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

Console warning from `class` prop usage in `SelectCard` #1494

Closed ssciolla closed 1 year ago

ssciolla commented 1 year ago

Thank you for contributing to this project!

Expected behavior (A description of what you expected to happen) :

There should be no Web console errors or warnings when using the UI.

Describe the bug (Tell us what happens instead of the expected behavior) :

There is a warning about an invalid prop name of class (as opposed to className). I introduced this accidentally in PR #1475. The warning is suppressed in production, so there is no visible error there.

Steps to Reproduce :

  1. Launch MyLA from a course, check you're on the view/visualization page.
  2. Check the Web console.
pushyamig commented 1 year ago

I will QA this

pushyamig commented 1 year ago

Test Passes. I don't see the error from any views including the home page. I ran the test from latest from my local