search

tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

Resolve issue for No Term from UDP course query #1504

Closed jonespm closed 1 year ago

jonespm commented 1 year ago

Zhen had a working fix for the UDP query on this other PR, should close this PR and open a new one with the fix

          Hmm, I pulled the list of all the course ids to use from our production to substitute in `%(course_ids)s` there are 537 courses defined there. 
SET SESSION group_concat_max_len = 16384;
select CONCAT("'", GROUP_CONCAT(id order by id SEPARATOR "','"), "'") from course where id is not null order by id;

The query on the PR 'as-is' only seems to return 51 rows, the query Zhen proposed returns 537 rows, our original query returns 537 rows.

So I'd probably close this one and @zqian can open one with her change.

Originally posted by @jonespm in https://github.com/tl-its-umich-edu/my-learning-analytics/issues/1499#issuecomment-1507523240

jonespm commented 1 year ago

The query fix was at https://github.com/tl-its-umich-edu/my-learning-analytics/pull/1499#issuecomment-1502118434

jennlove-um commented 1 year ago

Tested in MyLA beta.

Adding a course with No Term worked. The course was added and there were no error messages in the cron log for the course.