search

tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

#1513 updating python/node base to bookworm #1545

Closed pushyamig closed 8 months ago

pushyamig commented 8 months ago

Fixes #1513

pushyamig commented 8 months ago

@jonespm should I update the Node base to bookworm as well?

jonespm commented 8 months ago

Sure, I think that would have less impact since that's just being used for the build but you try to update it and if it builds great. Otherwise we might have to do it along with #1529

pushyamig commented 8 months ago

I have upgraded both the node/python base images to bookworm. builds fine

pushyamig commented 8 months ago

@jaydonkrooss I have added you as an observer, if you are still getting up to speed and not ready to run MyLA it's fine. @jonespm will be the approver.

jonespm commented 8 months ago

I had a draft PR #1512 that also was fixing this. It looks about the same but it was updating the Dockerfile.openshift that doesn't exist anymore. So this seems fine. I was waiting on MariaDB.

It looks like they didn't update their webpage but MariaDB added support in 2023-08-14 so we should be all set with that. I can close the other PR.