tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

I1542 GitHub branch fix #1549

Closed pushyamig closed 8 months ago

pushyamig commented 11 months ago

Fixes #1542

This PR address following things

  1. When a tag is created (via git tag 2017.01.01), auto builds and draft is created as pre-release. https://github.com/pushyamig/my-learning-analytics/releases/tag/untagged-c851e0a7738c70bbe025 https://github.com/pushyamig/my-learning-analytics/actions/runs/6657871566

  2. If user creates a release and publishes it from Github UI, This will trigger creation of tag, Github build is done all good. https://github.com/pushyamig/my-learning-analytics/releases/tag/1820.01.01 https://github.com/pushyamig/my-learning-analytics/actions/runs/6658577408

  3. Now the branches/tags are tagged as master, 2023.01.x, 2023.01.01 https://github.com/pushyamig/my-learning-analytics/pkgs/container/my-learning-analytics Screenshot 2023-10-26 at 3 14 52 PM

  4. You can also run any Build manually from UI https://github.com/pushyamig/my-learning-analytics/actions/workflows/main.yml Screenshot 2023-10-26 at 3 12 42 PM

To test these various scenarios, Take the main.yml and commit to master branch so that you could see the changes. Make sure you change the main.yml to point to your github repo and not tl-its-umich.edu

pushyamig commented 11 months ago

I recommend testing this locally, so many scenarios I might not be aware. and I did all this pointing to my repo

zqian commented 8 months ago

I have tested with a tag on my own fork: https://github.com/zqian/my-learning-analytics/releases/tag/2024.01.01

However, the following link does not work for me: https://github.com/zqian/my-learning-analytics/pkgs/container/my-learning-analytics

Any suggestions? @pushyamig

pushyamig commented 8 months ago

However, the following link does not work for me: https://github.com/zqian/my-learning-analytics/pkgs/container/my-learning-analytics

That's because we disabled Build otherthan TL repo. since we didnot for people fork of Myla to build automatically when a commit is made to master. https://github.com/zqian/my-learning-analytics/actions

if: github.repository_owner == 'tl-its-umich-edu'

Change this line to include your repo like if: github.repository_owner == 'tl-its-umich-edu' || github.repository_owner == 'zqian'

zqian commented 8 months ago

OK. After I made the changes as suggested in [3b88ea6], now the url works for me: https://github.com/zqian/my-learning-analytics/pkgs/container/my-learning-analytics

I have created new tag 2024.01.02 and pushed to my local repo, and saw the tagged image created and listed inside https://github.com/zqian/my-learning-analytics/pkgs/container/my-learning-analytics

Approve the PR now.

pushyamig commented 8 months ago

Thanks @zqian for review!