Closed pushyamig closed 8 months ago
This Draft PR is branched out of #1554 since that has major Backend updates. So it make sense to this way until that PR get merged
used CodeMods for updating the MUI to v5. here are the docs what gets updated https://github.com/mui/material-ui/blob/master/packages/mui-codemod/README.md
I have built the latest from this repo which is here https://github.com/pushyamig/my-learning-analytics/actions/runs/7413997544
This PR is now ready for Review, I have added test plan as well
I pretty much tested/reviewed it from my lense and things are ok .
I have updated things I tested according to test plan https://docs.google.com/spreadsheets/d/18c_VDE7wdme8c36Zo5-pjad77Kit8hFz4ylbmFXmLP8/edit#gid=0
I can't approve a PR which is opened by me. But I will approve the Jaydon's work as well
Fixes #1529 and #1525
react-router-dom
has some major changes, the nested router path are relative nowwithRoute
r higher order hook is removed, so need to write a custom functionpackage-lock.json
was just deletenode_module
and update thepackage.json
and generate a new lock file. This was simplest!@apollo/client
, Assignment planning was crashing so added a configuration optionassumeImmutableResults: false,
to enable mutable object of response which was allowed as an configuration option.npm-check-updates
for checking the latest package version in the repo. It is recommended by package dev to install it globally. https://www.npmjs.com/package/npm-check-updatesnpm install -g npm-check-updates
npm ls <package-name>
Eg.,npm ls postcss
Todo List:
Listitem
componentbutton
attribute seems deprecated ( it is stricked out in VsCode). Needs an understanding if any impact and any otherway to compensate it. Documentation will helpimport IconButton from '@mui/material/IconButton'
the iconButton Component addedsize='large'
to all filessx
prop. MUI v5 introduced this prop for inline styling for certain component. for older versionstyle
prop was used. I don't feel we need to replacestyle
withsx
but building some understanding will help. https://mui.com/system/getting-started/the-sx-prop/ https://stackoverflow.com/questions/72527461/when-should-i-use-style-instead-of-sx-prop-in-material-ui#:~:text=sx%20prop%20works%20only%20on,some%20cases%20as%20explained%20below.package-lock.json
commit - PushyamiJest testing as things are not working as expected(https://github.com/tl-its-umich-edu/my-learning-analytics/issues/1558)Test Plan
https://docs.google.com/spreadsheets/d/18c_VDE7wdme8c36Zo5-pjad77Kit8hFz4ylbmFXmLP8/edit#gid=0
Testing should be done from Student, instructor and MyLa Admin role