search

tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

1250: Add right margin for Resource Access percentages #1562

Closed jaydonkrooss closed 5 months ago

jaydonkrooss commented 5 months ago

Added a right margin for the bar chart, subtracting from the chart's width. Addresses the new bar chart percentages overlapping the brush slider https://github.com/tl-its-umich-edu/my-learning-analytics/issues/1250#issuecomment-1910967302

pushyamig commented 5 months ago

@jaydonkrooss at this point I would suggest you check with Jennifer and see if she is ok visually? I think changes look ok.

pushyamig commented 5 months ago

@jaydonkrooss this branch is not running from master and introduces the bug of not having % value on bar. Since this is showing the logic .style('fill', d => d.self_access_count > 0 ? 'white' : 'black') which is removed from master https://github.com/tl-its-umich-edu/my-learning-analytics/blob/master/assets/src/components/d3/createResourceAccessChart.js#L218

Screenshot 2024-01-26 at 1 55 56 PM
jaydonkrooss commented 5 months ago

@jaydonkrooss this branch is not running from master and introduces the bug of not having % value on bar. Since this is showing the logic .style('fill', d => d.self_access_count > 0 ? 'white' : 'black') which is removed from master https://github.com/tl-its-umich-edu/my-learning-analytics/blob/master/assets/src/components/d3/createResourceAccessChart.js#L218

Screenshot 2024-01-26 at 1 55 56 PM

weird, I thought my branch was up to date. I just merged in upstream/master, so I think it should be up to date now