tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

changes to issue #1358 regarding .git extension #1571

Closed niurcaq closed 5 months ago

niurcaq commented 5 months ago

I added a statement to replace the .git extension at the end no matter what format it is and ensures that the ssh base still converts to https. This should remove any .git extension from any format of a url when cloning or adding a remote repo. Here is our test plan:

Our test plan is to test four different urls:

The first test is to clone the repo with a https base url with the .git extension. The expected output is the same url but without the .git extension. This is to ensure that the https base gets the .git extension removed properly with our new code.

The second test is to clone the repo with a ssh base url with the .git extension. The expected output will return the github url as https base and will have the .git extension removed. This is to ensure that the shh base functionality still works with the new code.

The third test is to clone the repo with https base and no .git extension. The expected output will return the input string. This is to ensure that when an https base url is cloned without an extension, it still works properly and does not have any weird behavior.

The final test is to clone the repo with ssh base and no .git extension. The expected output will return the github url as https base with no other modifications. This is to ensure that the code works properly with the new code and does not have any weird behavior.