search

tl-its-umich-edu / my-learning-analytics

My Learning Analytics (MyLA)
Apache License 2.0
36 stars 39 forks source link

Switch to storing persistent volumes as part of Docker instead of in the filesystem. #1582

Closed jonespm closed 2 months ago

jonespm commented 4 months ago

In many of our apps the pattern has been to store the files in the local file system, but it seems better now to store these as persistent volumes in Docker. This would just involve adding a volume like this and referencing it instead of the local path. This would make the directory a little cleaner and easier to clean up.

This pattern is used in ROHQ https://github.com/tl-its-umich-edu/remote-office-hours-queue/blob/master/docker-compose.yml

volumes:
  db_data:

We might want to document that to remove this volume you'd have to remove the container and remove the volume associated with it.

https://github.com/tl-its-umich-edu/my-learning-analytics/blob/d08802ac37789ac8072d0aa1490ba5c0c0154ed4/docker-compose.yml#L16

jonespm commented 2 months ago

We may want to not include this. Pushyami noted that she removes volumes and this would remove this. So maybe it's not a good idea to change for MyLA.