tl-its-umich-edu / remote-office-hours-queue

Virtual queuing tool supporting Zoom video conferencing and/or in person meetings.
https://officehours.it.umich.edu/
Apache License 2.0
11 stars 28 forks source link

Evaluate use of `*` as required indicator #437

Open ssciolla opened 1 year ago

ssciolla commented 1 year ago

I know this is just adding a space here but it looks like using the HTML form validation is recommended over an * both for usage and accessibility.

https://www.accessibility-developer-guide.com/examples/forms/required/#using-html-5-client-side-validations https://react-bootstrap.netlify.app/docs/forms/validation

Was this not changed just because that's a separate (more effort) issue? We should probably file it as a new issue to fix it in the future.

_Originally posted by @jonespm in https://github.com/tl-its-umich-edu/remote-office-hours-queue/pull/435#discussion_r1234323441_

zqian commented 4 months ago

@jonespm needs to re-eval