User preferences Phone number bugs

[jaydonkrooss]

Address multiple regressions between QA and production on the user preferences page, where users can save and edit their phone information & text messaging preferences. Most likely introduced in PR for #391, so find out if some or all of these bugs can be addressed:

• clearing (backspace) and saving the empty phone number shows "your preferences were not saved" in QA. In production, does this properly remove the phone number for the user?
• unchecking "I want to be notified via SMS" shows preferences not saved - investigate how checking checkboxes gets saved
• trying out an invalid number created an empty warning message

[jaydonkrooss]

Hema and I noticed regressions from production when editing preferences and saving phone number changes. One key regression was that clearing the phone number (via backspace) doesn't save when clicking the save button. Let's look into if this can be fixed. One proposed solution is that we could add a new "clear phone number" button that removes the number and saves changes automatically.

[HemanginiShah]

All of the following testing was conducted in QA and highlights variances in messaging compared to the production environment. After removing the phone number using the backspace key, I clicked the save button. A message appeared stating, "Your preferences were not changed." Please refer to the screenshot below for details.

========= I re-entered the same phone number and received the following message:

====================== After selecting one of the checkboxes, the following message appeared:

========================== I unchecked both boxes and clicked on save, but the following message appeared, which doesn't seem correct.

================== I updated the number to an invalid value and clicked on 'Save'. The following error message appeared:

[HemanginiShah]

Additional Information on the Preferences Test Cases

1. Alert Message When Removing Phone Number:

   • Steps:
     1. Remove the previously saved phone number.
     2. Without changing previously selected checkboxes, click the "Save" button.
   • Expected Result:
     • The message displayed should be: "Your preferences were successfully updated."

2. Alert Message When Adding New Phone Number:

   • Steps:
     1. Update the phone number to +1 (555) 555-5555.
     2. Without selecting or updating any checkboxes, click the "Save" button.
   • Expected Result:
     • The message displayed should be: "Your preferences were successfully updated."

3. Alert Message When Updating with Same Phone Number:

   • Steps:
     1. Update the phone number to the same number, e.g., +1 (xxx) xxx-xxxx.
     2. Without selecting or updating any checkboxes, click the "Save" button.
   • Expected Result:
     • The message displayed should be: "Your preferences were not changed."

4. Alert Message Appears to Work When Updated with Checkboxes:

   • Steps:
     1. Select one of the checkboxes or both
     2. system checks if the phone number exists, if yes
     3. Click the "Save" button.
   • Expected Result:
     • The message displayed should be: "Your preferences were successfully updated."

5. Alert Message Appears to Work When Updated with Checkboxes:

   • Steps:
     1. Select one of the checkboxes or both
     2. system checks if the phone number exists, if phone number field is blank
     3. Click the "Save" button.
   • Expected Result:
     • The message displayed should be: "You must enter a phone number to opt in to host or attendee SMS notifications."

Note: The message "Your preferences were successfully updated" appears to work correctly only when a checkbox is updated. It does not work correctly when only the phone number is updated.

[HemanginiShah]

@jaydonkrooss I noticed a typo in #3 under test cases and have made update to the message that displays when no changes to phone number or check boxes are made.

[HemanginiShah]

@jaydonkrooss I have added rows 40-44. Given the recent changes, it's prudent to consider whether any adjustments are needed for the current prod version of the test cases listed in rows 45-51 of the 1.10 Full Test Plan. If updates are required then we update column E to Green YES and then we can proceed in two ways:

1. You can review and update the necessary changes to any or specific test case or
2. I can take the lead in updating the test cases, with you providing the impacted test cases required changes and I will make the update

This ensures that our Quality Assurance (QA) process, both pre and post, includes thorough verification aligned with the recent changes.

Let me know which approach you prefer or if there are any specific details you'd like to discuss further.

[jaydonkrooss]

@hemashahumich I will try to release the changes on the ROHQ dev instance so that you can start looking at the test cases. I think it'd be best if I could just show you the changes first, before you make the updates to the test cases as you see fit

[HemanginiShah]

@jaydonkrooss That sounds good.

*With Warm Regards,* https://www.name-coach.com/hemangini-shah

Hemangini Shah https://www.name-coach.com/hemangini-shah She/Her/Hers, PMP , BI Analyst Senior, ITS

Managing Services: Student Success Viewe https://its.umich.edu/academics-research/teaching-learning/student-success-viewer r, Remote Office Hour Queue https://its.umich.edu/communication/videoconferencing/remote-office-hours-queue , NameCoach https://its.umich.edu/academics-research/teaching-learning/namecoach, Perusall https://its.umich.edu/academics-research/teaching-learning/perusall

On Tue, Jun 18, 2024 at 3:02 PM jaydonkrooss @.***> wrote:

@hemashahumich https://github.com/hemashahumich I will try to release the changes on the ROHQ dev instance so that you can start looking at the test cases. I think it'd be best if I could just show you the changes first, before you make the updates to the test cases as you see fit

— Reply to this email directly, view it on GitHub https://github.com/tl-its-umich-edu/remote-office-hours-queue/issues/497#issuecomment-2176767875, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFEK2QDXJEVK4KG3HOCVTDDZIB73ZAVCNFSM6AAAAABINFD4J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWG43DOOBXGU . You are receiving this because you were mentioned.Message ID: @.*** com>

[HemanginiShah]

@jaydonkrooss Hello Jaydon, While testing, I noticed that if we delete a phone number, save the changes, and then re-enter the same number, it prompts for verification again. To address this, we might want to update the alert message to say: This number has been verified, but if cleared and saved again, it may require re-verification." Please let me know if you have any questions.

[jaydonkrooss]

The changes were already tested in canvas dev, so I'm moving this issue to Done.