search

tl-its-umich-edu / tool-migration

App for migrating external (LTI) tools in Instructure's Canvas LMS.
1 stars 3 forks source link

add basic Docker compose wrapper (iss. #15) #17

Closed lsloan closed 1 year ago

lsloan commented 1 year ago

Resolves #15.

Manage the application environment by providing a Docker compose wrapper to ensure the correct version of Python is available and dependencies are installed. Update the documentation accordingly and to address earlier concerns about it.

lsloan commented 1 year ago

@zqian, could you give this a review? It should be an easy approval. I'd like to get this to @ziegler1960 to test ASAP.

lsloan commented 1 year ago

@jonespm & @pushyamig, I've requested reviews from you on this, as well as Zhen. Whomever can review it first is appreciated. I've been told that this app is critical and Jeff needs to work with it ASAP, so getting this PR merged soon will help. I'm not working tomorrow, but I'll handle the merge and work with Jeff on Thursday.

jonespm commented 1 year ago

How is this script going to be run? I feel like having it in a container is a little unnecessary if it's just going to be a developer running it locally.

If it's a BSA I don't think we can expect them to install and learn how to use Docker to get this running, especially in Windows. There's more straight-forward ways of running Python CLI applications.

I think Docker container would make sense if this is going to be a job that will be run on Jenkins or run as a web application. I think I just don't know enough about this process to offer an approval here.

Commit if it you think it's for the best. I don't think all changes in all projects need an approval/review.

lsloan commented 1 year ago

@zqian & @jonespm, thanks for the feedback!

I agree about the code review and approval process, Matt. In this case, I thought Zhen probably wanted the changes to be reviewed. Your comments and hers have been helpful.

WRT Docker or something else, I'm happy to try alternative approaches. Matt, I'll DM you on Slack to describe my thought process that led to choosing Docker.